Skip to content

slack-vitess-r14.0.5: slack-cherrypick: revert backup compressor#79

Merged
tanjinx merged 6 commits intoslack-vitess-r14.0.5from
cherrypick-revert-backup-compressor
May 9, 2023
Merged

slack-vitess-r14.0.5: slack-cherrypick: revert backup compressor#79
tanjinx merged 6 commits intoslack-vitess-r14.0.5from
cherrypick-revert-backup-compressor

Conversation

@tanjinx
Copy link
Copy Markdown

@tanjinx tanjinx commented May 9, 2023

Description

similar as #25, we need to revert backup compressor from pargzip to pgzip, context in the old PR.

One difference this time is that the test changes were already in v14, and evolved in upstream by the PRs:

  852  wget https://github.com/slackhq/vitess/pull/25.patch
  867  git apply -v --include go/vt/mysqlctl/builtinbackupengine.go ~/25.patch
  869  git apply -v --include go/vt/mysqlctl/xtrabackupengine.go ~/25.patch

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@tanjinx tanjinx requested a review from a team as a code owner May 9, 2023 04:06
Copy link
Copy Markdown

@vmogilev vmogilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@tanjinx tanjinx merged commit 718242f into slack-vitess-r14.0.5 May 9, 2023
@tanjinx tanjinx deleted the cherrypick-revert-backup-compressor branch February 18, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants