Skip to content

[slack-19.0] Backport 18173 - CONNPOOL: Fix race condition when waiting for connection#712

Merged
tanjinx merged 3 commits intoslack-19.0from
backport-18173
Oct 16, 2025
Merged

[slack-19.0] Backport 18173 - CONNPOOL: Fix race condition when waiting for connection#712
tanjinx merged 3 commits intoslack-19.0from
backport-18173

Conversation

@tanjinx
Copy link

@tanjinx tanjinx commented Oct 9, 2025

Description

upstream backports:
vitessio#18713
vitessio#18722
vitessio#18719

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

arthurschreiber and others added 3 commits October 9, 2025 13:56
@arthurschreiber @mattlord @tanjinx
CONNPOOL: Fix race condition when waiting for connection (vitessio#18712
5f3b42b 
)

Signed-off-by: Arthur Schreiber <arthurschreiber@github.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
Co-authored-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
@arthurschreiber @tanjinx
connpool: Bump the hang detection timeout to 1 second. (vitessio#18722)
dfd6f2e 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@arthurschreiber @tanjinx
connpool: Don't use go internal sema functionality (vitessio#18719)
b074d5c 
Signed-off-by: Arthur Schreiber <arthur@planetscale.com>
@tanjinx tanjinx requested a review from a team as a code owner October 9, 2025 21:03
@salesforce-cla
Copy link

salesforce-cla bot commented Oct 9, 2025

Thanks for the contribution! Before we can merge this, we need @arthurschreiber to sign the Salesforce Inc. Contributor License Agreement.

@github-actions github-actions bot added this to the v19.0.7 milestone Oct 9, 2025
@ejortegau
Copy link

ejortegau commented Oct 10, 2025

Approved, though I see many tests/checks failing. Is it expected?

@tanjinx
Copy link
Author

tanjinx commented Oct 10, 2025

Approved, though I see many tests/checks failing. Is it expected?

yes, those 4 test failures are expected.. The upgrade/downgrade testing was because we set the downgrade version to 15, but now i think we can remove it. And for the vtorc testing failure, it was introduced by Tim's PR and he had a plan to fix it in a following PR, but I guess I will do that.

@tanjinx tanjinx merged commit 538e155 into slack-19.0 Oct 16, 2025
161 of 167 checks passed
@tanjinx tanjinx deleted the backport-18173 branch October 16, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ejortegau ejortegau ejortegau approved these changes

Assignees

No one assigned

Labels

cla:missing v23-backport

Projects

None yet

Milestone

v19.0.7

Development

Successfully merging this pull request may close these issues.

3 participants

@tanjinx @ejortegau @arthurschreiber