V12.0.5 workload table attribution metric instrumentation#70
Merged
ejortegau merged 5 commits intoslack-vitess-r12.0.5from Apr 13, 2023
Conversation
Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
We were using `CommentDirectives.IsSet()` which only returns true if the query directive's value is an integer or a boolean. By skipping this and simply calling `CommentDirectives.GetString()` we can get the string value of the directive or an empty string in case the workload name it is not set. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
timvaillancourt
approved these changes
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR backports the functionality of vitessio#12394 to our v12 fork.
Some changes were necessary with respect to the upstream PR due to the distance between v12
and the v16+ code against which the upstream change was built - particularly around the area of
query directive extraction; as well as the metrics that are instrumented.
This will not need to be ported to v14 it has been already included in #67 .