Skip to content

slack-19.0: tabletmanager: map sqlerrors to vtrpcpb/gRPC error codes#692

Closed
timvaillancourt wants to merge 13 commits intoslack-19.0from
bp-pr18565.slack-19.0
Closed

slack-19.0: tabletmanager: map sqlerrors to vtrpcpb/gRPC error codes#692
timvaillancourt wants to merge 13 commits intoslack-19.0from
bp-pr18565.slack-19.0

Conversation

@timvaillancourt
Copy link

@timvaillancourt timvaillancourt commented Aug 24, 2025

Description

This PR is an early backport of vitessio#18565 to slack-19.0

Before w/mysqld killed

rpc error: code = Unknown desc = TabletManager.StopReplicationAndGetStatus on REDACTED-TABLETALIAS: before status failed: net.Dial(/mnt/vitess/mysql/datadir/mysql.sock) to local server failed: dial unix /mnt/vitess/mysql/datadir/mysql.sock: connect: connection refused (errno 2002) (sqlstate HY000)

After w/mysqld killed + test client

rpc error: code = Unavailable desc = TabletManager.StopReplicationAndGetStatus on REDACTED-TABLETALIAS: before status failed: net.Dial(/mnt/vitess/mysql/datadir/mysql.sock) to local server failed: dial unix /mnt/vitess/mysql/datadir/mysql.sock: connect: connection refused (errno 2002) (sqlstate HY000)

🎉

Related Issue(s)

vitessio#18565

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@github-actions github-actions bot added this to the v19.0.7 milestone Aug 24, 2025
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt marked this pull request as ready for review August 25, 2025 17:31
@timvaillancourt timvaillancourt requested a review from a team as a code owner August 25, 2025 17:31
@timvaillancourt timvaillancourt changed the title slack-19.0: tabletmanager: map sqlerrors to vtrpcpb codes slack-19.0: tabletmanager: map sqlerrors to vtrpcpb/gRPC error codes Aug 25, 2025
@github-actions
Copy link

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale label Sep 25, 2025
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

This PR was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant