Skip to content

slack-19.0: add keyspace/shard labels to VTOrc recoveries stats#654

Merged
timvaillancourt merged 3 commits intoslack-19.0from
bp-pr18304.slack-19.0
May 28, 2025
Merged

slack-19.0: add keyspace/shard labels to VTOrc recoveries stats#654
timvaillancourt merged 3 commits intoslack-19.0from
bp-pr18304.slack-19.0

Conversation

@timvaillancourt
Copy link

@timvaillancourt timvaillancourt commented May 27, 2025 •
edited
Loading

Description

This PR backports (early) v23 PR vitessio#18304 to slack-19.0

Related Issue(s)

vitessio#18304

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@timvaillancourt
vtorc: add keyspace/shard labels to recoveries stats
121a6c3 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt self-assigned this May 27, 2025
@timvaillancourt timvaillancourt requested a review from a team as a code owner May 27, 2025 14:33
@timvaillancourt timvaillancourt changed the title vtorc: add keyspace/shard labels to recoveries stats slack-19.0: add keyspace/shard labels to VTOrc recoveries stats May 27, 2025
@github-actions github-actions bot added this to the v19.0.7 milestone May 27, 2025
tanjinx
tanjinx previously approved these changes May 27, 2025
View reviewed changes
@tanjinx tanjinx self-requested a review May 27, 2025 17:36
@timvaillancourt
add keyspace/shard to utils.WaitForSuccessfulRecoveryCount
6cfcf9f 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
make var once
7cffba7 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt requested a review from a team May 27, 2025 20:57
@timvaillancourt timvaillancourt merged commit c545d06 into slack-19.0 May 28, 2025
163 of 165 checks passed
@timvaillancourt timvaillancourt deleted the bp-pr18304.slack-19.0 branch May 28, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ejortegau ejortegau ejortegau approved these changes

@tanjinx tanjinx Awaiting requested review from tanjinx

Assignees

@timvaillancourt timvaillancourt

Labels

Component: VTOrc upstream-backport An upstream backport v19 v23-backport

Projects

None yet

Milestone

v19.0.7

Development

Successfully merging this pull request may close these issues.

3 participants

@timvaillancourt @ejortegau @tanjinx