Skip to content

slack-21.0: backport v22 VTOrc fixes, part 1#610

Merged
timvaillancourt merged 13 commits intoslack-21.0from
vtorc-bps.slack-21.0
Feb 20, 2025
Merged

slack-21.0: backport v22 VTOrc fixes, part 1#610
timvaillancourt merged 13 commits intoslack-21.0from
vtorc-bps.slack-21.0

Conversation

@timvaillancourt
Copy link

@timvaillancourt timvaillancourt commented Feb 19, 2025 •
edited
Loading

Description

This PR backports all VTOrc patches from v22 that we currently run on slack-19.0:

  1. Move to native sqlite3 queries vitessio/vitess#17124
  2. Improve efficiency of vtorc topo calls  vitessio/vitess#17071
  3. Ensure all topo read calls consider --topo_read_concurrency vitessio/vitess#17276
  4. Avoid flaky topo concurrency test vitessio/vitess#17407
  5. vtorc: fetch all tablets from cells once + filter during refresh vitessio/vitess#17388
  6. Use prefix in all vtorc check and recover logs vitessio/vitess#17526
  7. Support KeyRange in --clusters_to_watch flag vitessio/vitess#17604
  8. vtorc: improve handling of partial cell topo results vitessio/vitess#17718
  9. Add stats for shards watched by VTOrc, purge stale shards vitessio/vitess#17815 (early backport)

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

dbussink and others added 11 commits February 19, 2025 19:03
@dbussink @timvaillancourt
Move to native sqlite3 queries (vitessio#17124)
87b90ed 
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt @mattlord
Improve efficiency of vtorc topo calls (vitessio#17071)
2a4cb9a 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: Matt Lord <mattalord@gmail.com>
@timvaillancourt
Ensure all topo read calls consider --topo_read_concurrency (vitess…
72a2d0c 
…io#17276)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
Avoid flaky topo concurrency test (vitessio#17407)
678cbdc 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
vtorc: fetch all tablets from cells once + filter during refresh (v…
7a533d5 
…itessio#17388)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@GuptaManan100 @timvaillancourt
Support KeyRange in --clusters_to_watch flag (vitessio#17604)
a01bca6 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@timvaillancourt
vtorc: improve handling of partial cell topo results (vitessio#17718)
3edd8a8 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
Add stats for shards watched by VTOrc
d515ebc 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
add more tests
468c0e7 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
cleanup
1defa65 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt
fix ineffassign
441b294 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@salesforce-cla
Copy link

salesforce-cla bot commented Feb 19, 2025

Thanks for the contribution! Before we can merge this, we need @dbussink @GuptaManan100 to sign the Salesforce Inc. Contributor License Agreement.

@github-actions github-actions bot added this to the v21.0.3 milestone Feb 19, 2025
@timvaillancourt timvaillancourt marked this pull request as ready for review February 19, 2025 18:19
@timvaillancourt timvaillancourt requested a review from a team as a code owner February 19, 2025 18:19
timvaillancourt and others added 2 commits February 19, 2025 19:29
@timvaillancourt
fix test for v21
9da51d8 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@ejortegau @timvaillancourt
Use prefix in all vtorc check and recover logs (vitessio#17526)
2b705a5 
Signed-off-by: Eduardo J. Ortega U. <5791035+ejortegau@users.noreply.github.com>
@timvaillancourt timvaillancourt merged commit 1f5ac88 into slack-21.0 Feb 20, 2025
184 of 185 checks passed
@timvaillancourt timvaillancourt deleted the vtorc-bps.slack-21.0 branch February 20, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tanjinx tanjinx tanjinx approved these changes

Assignees

No one assigned

Labels

cla:missing upstream-backport An upstream backport v21 v22-backport

Projects

None yet

Milestone

v21.0.3

Development

Successfully merging this pull request may close these issues.

5 participants

@timvaillancourt @tanjinx @dbussink @GuptaManan100 @ejortegau