slack-19.0: early backport of vtorc optimizations, pt. 1#549
Closed
timvaillancourt wants to merge 2 commits intoslack-19.0from
Closed
slack-19.0: early backport of vtorc optimizations, pt. 1#549timvaillancourt wants to merge 2 commits intoslack-19.0from
slack-19.0: early backport of vtorc optimizations, pt. 1#549timvaillancourt wants to merge 2 commits intoslack-19.0from
Conversation
We don't have to support anything but sqlite3 here, so let's use the proper sqlite syntax. This allows removing the find / replace logic and regexp matching which reduces vtorc CPU usage significantly. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
timvaillancourt
added
upstream-backport
|
Thanks for the contribution! Before we can merge this, we need @dbussink to sign the Salesforce Inc. Contributor License Agreement. |
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt
force-pushed
the
bp-vtorc-optimizations.slack-19.0
branch
from
96e1617 to
38f8a6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is an early backport of these
vtorcoptimizations:vtorctopo calls vitessio/vitess#17071vtorc: use sqlite3 SQL dialect only vitessio/vitess#17120Following some fixes of nits + merge upstream, I'll re-backport
Related Issue(s)
vitessio#17114
Checklist
Deployment Notes