Merged
Conversation
Signed-off-by: 'Renan Rangel' <rrangel@slack-corp.com>
Signed-off-by: 'Renan Rangel' <rrangel@slack-corp.com>
…ssio#17000) Signed-off-by: Renan Rangel <rrangel@slack-corp.com> Signed-off-by: 'Renan Rangel' <rrangel@slack-corp.com>
Signed-off-by: 'Renan Rangel' <rrangel@slack-corp.com>
Signed-off-by: 'Renan Rangel' <rrangel@slack-corp.com>
tanjinx
reviewed
Oct 24, 2024
| @@ -352,21 +354,6 @@ func Restore(ctx context.Context, params RestoreParams) (*BackupManifest, error) | |||
| return nil, err | |||
| } | |||
There was a problem hiding this comment.
looks like ShouldStartMySQLAfterRestore is not checked online 350-352? or it's no longer needed? the original change https://github.com/vitessio/vitess/pull/16295/files#diff-b99512e7a77c7bd6ad4dcdd037ebc57754be363e0148c67bb22886cd4fbc1d80R450
Author
There was a problem hiding this comment.
that's a good catch, thanks Tanjin. I think this got removed because we don't exactly need it on our setup because of the hooks, but there is no reason it shouldn't be backported too. I have added it there
tanjinx
previously approved these changes
Oct 24, 2024
tanjinx
left a comment
tanjinx
left a comment
There was a problem hiding this comment.
other than the comment about "ShouldStartMySQLAfterRestore", others LGTM by comparing to the upstream PR. 🎉
Signed-off-by: 'Renan Rangel' <rrangel@slack-corp.com>
timvaillancourt
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This backports the new logical backups engine added upstream in vitessio#16295, as well as a fix for it in vitessio#17000
Related Issue(s)
Checklist
Deployment Notes