Skip to content

Backport: Allow override of build git env in docker/base builds (#11968)#53

Merged
timvaillancourt merged 1 commit intoslack-vitess-r12.0.5from
slack-vitess-r12.0.5-pr11968
Mar 10, 2023
Merged

Backport: Allow override of build git env in docker/base builds (#11968)#53
timvaillancourt merged 1 commit intoslack-vitess-r12.0.5from
slack-vitess-r12.0.5-pr11968

Conversation

@timvaillancourt
Copy link
Copy Markdown

@timvaillancourt timvaillancourt commented Mar 9, 2023 •
edited
Loading

Description

Backport of upstream PR: vitessio#11968

Related Issue(s)

vitessio#11968

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@timvaillancourt @frouioui
Allow override of build git env in docker/base builds (vitessio#11968)
9346eff 
* Pass BUILD_GIT_BRANCH and BUILD_GIT_REV env into docker build

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Fix bootstrap version

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Fix bootstrap version, again

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Fix ws

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
@timvaillancourt timvaillancourt merged commit 65fa9e8 into slack-vitess-r12.0.5 Mar 10, 2023
@timvaillancourt timvaillancourt deleted the slack-vitess-r12.0.5-pr11968 branch March 10, 2023 11:33
@timvaillancourt timvaillancourt added v12 upstream-backport An upstream backport labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbibra pbibra Awaiting requested review from pbibra

@tanjinx tanjinx Awaiting requested review from tanjinx

1 more reviewer

@darenseagrave darenseagrave darenseagrave approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

upstream-backport An upstream backport v12

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timvaillancourt @darenseagrave