Skip to content

Backport of PR #12992#505

Closed
maksimov wants to merge 3 commits intoslack-15.0from
pr-12992-slack-15.0
Closed

Backport of PR #12992#505
maksimov wants to merge 3 commits intoslack-15.0from
pr-12992-slack-15.0

Conversation

@maksimov
Copy link

@maksimov maksimov commented Sep 9, 2024

Description

This is a backport of PR vitessio#12992 which failed to get backported to v15 back in the day, so now we have to make our own patch.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

…donly and replica tablets during a resharding event (vitessio#12992)

* use switcher struct when switching shard reads during a reshard event

Signed-off-by: austenLacy <austenlacy@gmail.com>

* Create failing test for bug reported in vitessio#12992, where a TrafficSwitch dry run for reads during resharding tries to actually switch reads and fails

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

---------

Signed-off-by: austenLacy <austenlacy@gmail.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: Rohit Nayak <rohit@planetscale.com>
@maksimov maksimov requested a review from a team as a code owner September 9, 2024 22:32
@salesforce-cla
Copy link

salesforce-cla bot commented Sep 9, 2024

Thanks for the contribution! Before we can merge this, we need @austenLacy to sign the Salesforce Inc. Contributor License Agreement.

@github-actions github-actions bot added this to the v15.0.5 milestone Sep 9, 2024
@maksimov maksimov marked this pull request as draft September 9, 2024 22:34
@maksimov maksimov marked this pull request as ready for review September 9, 2024 23:16
@maksimov
Copy link
Author

See #508

@maksimov maksimov closed this Sep 11, 2024
@maksimov maksimov deleted the pr-12992-slack-15.0 branch September 11, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants