[Backport] VReplication: Make Source Tablet Selection More Robust (#13582)#495
Closed
makinje16 wants to merge 6 commits intoslack-15.0from
Closed
[Backport] VReplication: Make Source Tablet Selection More Robust (#13582)#495makinje16 wants to merge 6 commits intoslack-15.0from
makinje16 wants to merge 6 commits intoslack-15.0from
Conversation
|
Thanks for the contribution! Before we can merge this, we need @mattlord to sign the Salesforce Inc. Contributor License Agreement. |
Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Malcolm Akinje <makinje@slack-corp.com>
…492) * WIP Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update all flags Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update e2e flag test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * 2 missing flags Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * rename Type() Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * empty commit to test ci Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fakesqldb: Guard query log usage with lock (vitessio#12813) * fakesqldb: Guard query log usage with lock This lock is used around adding to the query log, but it means we also need to use the lock when reading from it or when resetting it. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * grpcvtctldserver: Fix alias for loop reuse Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * unit_race: Increase runtime We've been adding a lot of tests for the evalengine and we're bumping up to the timeout. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> --------- Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * remove t.Parallel() like upstream did Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
* `txthrottler`: move `ThrottlerInterface` to `go/vt/throttler`, use `slices` pkg, add stats (vitessio#16248) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * revert to `reflect` Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Support passing filters to `discovery.NewHealthCheck(...)` Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Update go/vt/vttablet/tabletserver/txthrottler/tx_throttler.go Co-authored-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Address some PR suggestions Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * PR ctx suggestion Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * simplify updateHealthCheckCells signature Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix race in `replicationLagModule` of `go/vt/throttle` Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Matt Lord <mattalord@gmail.com>
makinje16
force-pushed
the
backport-upstream-13582
branch
from
ca3fb9b to
cf624ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR backports #13582 in order to fix the
NOT_FOUNDerrors we've seen on the CDC project during tablet failure on the streaming host.Related Issue(s)
Checklist
Deployment Notes