Allow setting grpc send and recv message sizes independently#481
Merged
pbibra merged 4 commits intoslack-15.0from Aug 12, 2024
Merged
Allow setting grpc send and recv message sizes independently#481pbibra merged 4 commits intoslack-15.0from
pbibra merged 4 commits intoslack-15.0from
Conversation
Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>
Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>
|
this lgtm! I think we'll want to update all the txt help files with the two new flags to get some of the unit tests passing. Since they all use these grpc common options topo2topo.txt |
Author
|
@pbibra where are those files? I don't see them in my slack-15 checkout (alternatively, which tests should I run locally to trigger those failures?) |
Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>
Author
|
@pbibra I found some of them, let me know if others (like topo2topo.txt) still need updating. |
rjlaine
previously approved these changes
Aug 12, 2024
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
No sorry! That list was from the v19 branch - you got all of them here! The tests are in |
pbibra
approved these changes
Aug 12, 2024
tanjinx
pushed a commit
that referenced
this pull request
Oct 24, 2024
* Allow setting grpc send and recv message sizes independently Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * Add comments Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * Update .txt files Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * update help txt ordering Signed-off-by: Priya Bibra <pbibra@slack-corp.com> --------- Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Co-authored-by: Priya Bibra <pbibra@slack-corp.com>
4 tasks
tanjinx
added a commit
that referenced
this pull request
Oct 24, 2024
…ntly (#481) (#540) * Allow setting grpc send and recv message sizes independently (#481) * Allow setting grpc send and recv message sizes independently Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * Add comments Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * Update .txt files Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * update help txt ordering Signed-off-by: Priya Bibra <pbibra@slack-corp.com> --------- Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Co-authored-by: Priya Bibra <pbibra@slack-corp.com> * remove vtgr * fix test * fix spaces --------- Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Co-authored-by: Henry Robinson <hrobinson@slack-corp.com> Co-authored-by: Priya Bibra <pbibra@slack-corp.com>
tanjinx
added a commit
that referenced
this pull request
Feb 3, 2026
…ntly (#481) (#540) * Allow setting grpc send and recv message sizes independently (#481) * Allow setting grpc send and recv message sizes independently Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * Add comments Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * Update .txt files Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * update help txt ordering Signed-off-by: Priya Bibra <pbibra@slack-corp.com> --------- Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Co-authored-by: Priya Bibra <pbibra@slack-corp.com> * remove vtgr * fix test * fix spaces --------- Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Co-authored-by: Henry Robinson <hrobinson@slack-corp.com> Co-authored-by: Priya Bibra <pbibra@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com>
5 tasks
tanjinx
added a commit
that referenced
this pull request
Feb 3, 2026
…sizes independe… (#787) * forward-fit: Allow setting grpc send and recv message sizes independently (#481) (#540) * Allow setting grpc send and recv message sizes independently (#481) * Allow setting grpc send and recv message sizes independently Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * Add comments Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * Update .txt files Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * update help txt ordering Signed-off-by: Priya Bibra <pbibra@slack-corp.com> --------- Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Co-authored-by: Priya Bibra <pbibra@slack-corp.com> * remove vtgr * fix test * fix spaces --------- Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Co-authored-by: Henry Robinson <hrobinson@slack-corp.com> Co-authored-by: Priya Bibra <pbibra@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * Remove accidentally committed vtgateproxy binary Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> --------- Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> Co-authored-by: Henry Robinson <hrobinson@slack-corp.com> Co-authored-by: Priya Bibra <pbibra@slack-corp.com> Co-authored-by: Claude <svc-devxp-claude@slack-corp.com>
sbaker617
pushed a commit
that referenced
this pull request
Feb 5, 2026
…sizes independe… (#787) * forward-fit: Allow setting grpc send and recv message sizes independently (#481) (#540) * Allow setting grpc send and recv message sizes independently (#481) * Allow setting grpc send and recv message sizes independently Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * Add comments Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * Update .txt files Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * update help txt ordering Signed-off-by: Priya Bibra <pbibra@slack-corp.com> --------- Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Co-authored-by: Priya Bibra <pbibra@slack-corp.com> * remove vtgr * fix test * fix spaces --------- Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Co-authored-by: Henry Robinson <hrobinson@slack-corp.com> Co-authored-by: Priya Bibra <pbibra@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> * Remove accidentally committed vtgateproxy binary Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> --------- Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> Co-authored-by: Henry Robinson <hrobinson@slack-corp.com> Co-authored-by: Priya Bibra <pbibra@slack-corp.com> Co-authored-by: Claude <svc-devxp-claude@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would like to set the send and recv max message sizes independently on vtgates. This allows us to keep a small limit on the size of the messages received from tablets, while allowing vtgates to send a large aggregated response to clients.
Two new flags are added:
grpc_max_message_send_sizeandgrpc_max_message_recv_size. These are 0 by default, in which case the existinggrpc_max_message_sizeflag is used with no change from the existing behaviour. If set to non-0, they override the setting forgrpc_max_message_size.