`slack-19.0`: merge `v19.0.5` patch release by timvaillancourt · Pull Request #471 · slackhq/vitess

timvaillancourt · 2024-07-30T16:58:38Z

Description

This PR merges the new v19.0.5 patch release onto slack-19.0, which was based on v19.0.4

This was done simply by pulling-down the new tag, running git merge v19.0.5 on this slack-19.0-based branch and fixing a few conflicts

Related Issue(s)

Checklist

"Backport to:" labels have been added if this change should be back-ported
Tests were added or are not required
Did the new or modified tests pass consistently locally and on the CI
Documentation was added or is not required

Deployment Notes

…vitessio#15889) Signed-off-by: Andres Taylor <andres@planetscale.com>

…ssio#15906) Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

…#15850) Signed-off-by: notfelineit <notfelineit@gmail.com> Signed-off-by: <> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Frances Thai <francesthai@Francess-MacBook-Pro.local>

…n Mac (vitessio#15835) (vitessio#15915) Signed-off-by: bddicken <bddicken@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

…f add join predicate on rewrite (vitessio#15956) (vitessio#15960) Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com>

…n the bind variables map (vitessio#15961) (vitessio#15967) Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>

…ssio#15964) Signed-off-by: Andres Taylor <andres@planetscale.com>

…) (vitessio#16003) Signed-off-by: Vicent Marti <vmg@strn.cat> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

…#16019) (vitessio#16027) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: frouioui <frouioui@users.noreply.github.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

…ssio#15715) (vitessio#16100) Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>

…vtorc (vitessio#15991) (vitessio#16103) Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Frances Thai <notfelineit@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

…ssio#16132) Co-authored-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

…ght_string` results correctly. (vitessio#16129) (vitessio#16157) Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

…#16159) (vitessio#16167) Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>

…in self referencing FK (vitessio#16205) (vitessio#16207) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

…essio#16212) Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

…ssio#16174) (vitessio#16185) Co-authored-by: Andrés Taylor <andres@planetscale.com>

…ssio#16198) Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

…ting workflow streams in the copy phase (vitessio#16217) (vitessio#16222) Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>

…Rules commands don't work (vitessio#16096) (vitessio#16124) Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>

…tessio#16263) (vitessio#16267) Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> Co-authored-by: Andres Taylor <andres@planetscale.com>

…te` image for the MySQL container (vitessio#16282) (vitessio#16285) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>

…ary in Reshard (vitessio#16283) (vitessio#16291) Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com>

… (vitessio#16332) Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com>

Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: frouioui <frouioui@users.noreply.github.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

…o#16340) (vitessio#16346) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

…io#16353) (vitessio#16359) Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com>

…sio#16386) (vitessio#16389) Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

…itessio#16366) (vitessio#16384) Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andrés Taylor <andres@planetscale.com>

…le is empty (vitessio#16393) (vitessio#16410) Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

…ed in order by as long as we can merge it all into a single route (vitessio#16402) (vitessio#16407) Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

…uting rules (vitessio#16383) (vitessio#16406) Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>

…ork overhead (vitessio#16153) (vitessio#16191) Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andrés Taylor <andres@planetscale.com>

Signed-off-by: Andres Taylor <andres@planetscale.com>

salesforce-cla · 2024-07-30T16:58:42Z

Thanks for the contribution! Before we can merge this, we need @systay @vitess-bot @GuptaManan100 @harshit-gangal to sign the Salesforce Inc. Contributor License Agreement.

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

systay and others added 30 commits May 8, 2024 16:26

[release-19.0] Bump to v19.0.5-SNAPSHOT after the v19.0.4 release (…

5a5975e

…vitessio#15889) Signed-off-by: Andres Taylor <andres@planetscale.com>

[release-19.0] fix: handle info_schema routing (vitessio#15899) (vite…

2eaf6d1

…ssio#15906) Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

[release-19.0] Update env.sh so that is does not error when running o…

61ece6f

…n Mac (vitessio#15835) (vitessio#15915) Signed-off-by: bddicken <bddicken@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

[release-19.0] test: Cleaner plan tests output (vitessio#15922) (vite…

e49855a

…ssio#15964) Signed-off-by: Andres Taylor <andres@planetscale.com>

[release-19.0] connpool: Allow time out during shutdown (vitessio#15979…

6bfdccf

…) (vitessio#16003) Signed-off-by: Vicent Marti <vmg@strn.cat> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

[release-19.0] fix: remove keyspace when merging subqueries (vitessio…

4f5b9d9

…#16019) (vitessio#16027) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

[release-19.0] Add DCO workflow (vitessio#16052) (vitessio#16056)

903dbe5

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

[release-19.0] Remove DCO workaround (vitessio#16087) (vitessio#16091)

536e161

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

[release-19.0] Do not load table stats when booting vttablet. (vite…

c1211d6

…ssio#15715) (vitessio#16100) Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>

[release-19.0] Add timeout to all the contexts used for RPC calls in …

5bd7d37

…vtorc (vitessio#15991) (vitessio#16103) Signed-off-by: Manan Gupta <manan@planetscale.com>

[release-19.0] Update braces package (vitessio#16115) (vitessio#16118)

741a026

Signed-off-by: Frances Thai <notfelineit@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

[release-19.0] fix: order by subquery planning (vitessio#16049) (vite…

2d16a00

…ssio#16132) Co-authored-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

Run more test on release-19 branch (vitessio#16152)

c092915

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

[release-19.0] Fix flakiness in vtexplain unit test case. (vitessio…

6ff19c9

…#16159) (vitessio#16167) Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>

[release-19.0] Handle Nullability for Columns from Outer Tables (vite…

89ab334

…ssio#16174) (vitessio#16185) Co-authored-by: Andrés Taylor <andres@planetscale.com>

[release-19.0] VDiff CLI: Fix VDiff show bug (vitessio#16177) (vite…

124486c

…ssio#16198) Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

[release-19.0] VReplication Workflow: set state correctly when restar…

4f6f80f

…ting workflow streams in the copy phase (vitessio#16217) (vitessio#16222) Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>

[release-19.0] vtctldclient: Apply (Shard | Keyspace| Table) Routing …

9548d15

…Rules commands don't work (vitessio#16096) (vitessio#16124) Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>

[release-19.0] Fix vtgate crash in group concat (vitessio#16254)

c00cf4f

Signed-off-by: Manan Gupta <manan@planetscale.com>

[release-19.0] VReplication: Properly handle target shards w/o a prim…

a837318

…ary in Reshard (vitessio#16283) (vitessio#16291) Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com>

vitess-bot and others added 13 commits July 3, 2024 16:41

[release-19.0] Fix the install dependencies script in Docker (vitessi…

3f3a104

…o#16340) (vitessio#16346) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

[release-19.0] planner: Handle ORDER BY inside derived tables (vitess…

bf16935

…io#16353) (vitessio#16359) Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com>

[release-19.0] fix issue with aggregation inside of derived tables (v…

6a9bb31

…itessio#16366) (vitessio#16384) Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andrés Taylor <andres@planetscale.com>

[release-19.0] Use default schema reload config values when config fi…

98262aa

…le is empty (vitessio#16393) (vitessio#16410) Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

[release-19.0] Fix panic in schema tracker in presence of keyspace ro…

711730d

…uting rules (vitessio#16383) (vitessio#16406) Signed-off-by: Manan Gupta <manan@planetscale.com>

[release-19.0] feat: add a LIMIT 1 on EXISTS subqueries to limit netw…

697e1b5

…ork overhead (vitessio#16153) (vitessio#16191) Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andrés Taylor <andres@planetscale.com>

[release-19.0] Code Freeze for v19.0.5 (vitessio#16448)

1d73195

Signed-off-by: Andres Taylor <andres@planetscale.com>

[release-19.0] Release of v19.0.5 (vitessio#16450)

365c4ca

Signed-off-by: Andres Taylor <andres@planetscale.com>

Merge tag 'v19.0.5' into v19.0.5_slack-19.0

59a8012

salesforce-cla bot added the cla:missing label Jul 30, 2024

github-actions bot added this to the v19.0.4 milestone Jul 30, 2024

timvaillancourt changed the title ~~V19.0.5 slack 19.0~~ slack-19.0: merge v19.0.5 patch release Jul 30, 2024

Fix new test

b1eb3e8

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

timvaillancourt marked this pull request as ready for review July 30, 2024 20:54

timvaillancourt requested a review from a team as a code owner July 30, 2024 20:54

roderickyao approved these changes Aug 7, 2024

View reviewed changes

timvaillancourt merged commit c356cdb into slack-19.0 Aug 7, 2024

timvaillancourt deleted the v19.0.5_slack-19.0 branch August 7, 2024 16:52

timvaillancourt modified the milestones: v19.0.4, v19.0.5 Sep 10, 2024

timvaillancourt modified the milestones: v19.0.5, v19.0.7 Feb 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`slack-19.0`: merge `v19.0.5` patch release#471

`slack-19.0`: merge `v19.0.5` patch release#471
timvaillancourt merged 44 commits intoslack-19.0from
v19.0.5_slack-19.0

timvaillancourt commented Jul 30, 2024 •

edited

Loading

Uh oh!

salesforce-cla bot commented Jul 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

timvaillancourt commented Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue(s)

Checklist

Deployment Notes

Uh oh!

salesforce-cla bot commented Jul 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

timvaillancourt commented Jul 30, 2024 •

edited

Loading