slack-19.0: add structured logging#449
Merged
timvaillancourt merged 9 commits intoslack-19.0from Jul 10, 2024
Merged
Conversation
Signed-off-by: Emad Habib <ehabib@slack-corp.com>
Signed-off-by: Emad Habib <ehabib@slack-corp.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
|
Thanks for the contribution! Before we can merge this, we need @EmadMokhtar to sign the Salesforce Inc. Contributor License Agreement. |
timvaillancourt
changed the title
slack-19.0 add structured loggingslack-19.0: add structured logging
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
4 tasks
tanjinx
pushed a commit
that referenced
this pull request
Feb 3, 2026
* Install zap log and noglog Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Implement the Vitess Structure Logger VTSLoger Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Move the structure logging code to logger.go file * make PR suggestions from vitessio#13061 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix bad merge conflict Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix bad merge conflict again Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * add flags e2e test for vtgateclienttest Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update error msg Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Emad Habib <ehabib@slack-corp.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Emad Habib <ehabib@slack-corp.com> Co-authored-by: Emad Mokhtar <me@emadmokhtar.com>
5 tasks
tanjinx
added a commit
that referenced
this pull request
Feb 4, 2026
* `slack-19.0`: add structured logging (#449) * Install zap log and noglog Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Implement the Vitess Structure Logger VTSLoger Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Move the structure logging code to logger.go file * make PR suggestions from vitessio#13061 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix bad merge conflict Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix bad merge conflict again Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * add flags e2e test for vtgateclienttest Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update error msg Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Emad Habib <ehabib@slack-corp.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Emad Habib <ehabib@slack-corp.com> Co-authored-by: Emad Mokhtar <me@emadmokhtar.com> * `slack-19.0`: fix structured logging (#532) * `slack-19.0`: fix structured logging Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * remove debug println Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * test cleanup Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update flags and e2e tests Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix e2e flag test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * code cleanup Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * simplify Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix goimports Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * log_dir WIP Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Add structured logging flags to RegisterFlagsWithTimeouts The cherry-picked structured logging commits added the flags to RegisterFlags() but not to RegisterFlagsWithTimeouts(). This caused mysqlctld (which uses RegisterFlagsWithTimeouts) to not have the structured logging flags available. This commit adds the --structured-logging and --structured-log-level flags to RegisterFlagsWithTimeouts() to match RegisterFlags(). Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> --------- Signed-off-by: Emad Habib <ehabib@slack-corp.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Emad Habib <ehabib@slack-corp.com> Co-authored-by: Emad Mokhtar <me@emadmokhtar.com> Co-authored-by: Claude <svc-devxp-claude@slack-corp.com>
sbaker617
pushed a commit
that referenced
this pull request
Feb 5, 2026
* `slack-19.0`: add structured logging (#449) * Install zap log and noglog Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Implement the Vitess Structure Logger VTSLoger Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Move the structure logging code to logger.go file * make PR suggestions from vitessio#13061 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix bad merge conflict Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix bad merge conflict again Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * add flags e2e test for vtgateclienttest Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update error msg Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Emad Habib <ehabib@slack-corp.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Emad Habib <ehabib@slack-corp.com> Co-authored-by: Emad Mokhtar <me@emadmokhtar.com> * `slack-19.0`: fix structured logging (#532) * `slack-19.0`: fix structured logging Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * remove debug println Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * test cleanup Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update flags and e2e tests Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix e2e flag test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * code cleanup Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * simplify Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix goimports Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * log_dir WIP Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Add structured logging flags to RegisterFlagsWithTimeouts The cherry-picked structured logging commits added the flags to RegisterFlags() but not to RegisterFlagsWithTimeouts(). This caused mysqlctld (which uses RegisterFlagsWithTimeouts) to not have the structured logging flags available. This commit adds the --structured-logging and --structured-log-level flags to RegisterFlagsWithTimeouts() to match RegisterFlags(). Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> --------- Signed-off-by: Emad Habib <ehabib@slack-corp.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Tanjin Xu <tanjin.xu@slack-corp.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Emad Habib <ehabib@slack-corp.com> Co-authored-by: Emad Mokhtar <me@emadmokhtar.com> Co-authored-by: Claude <svc-devxp-claude@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is the not-yet-upstreamed vitessio#13061 with the review suggestions from the comments applied
Related Issue(s)
vitessio#13061
Checklist
Deployment Notes