slack-15.0: Fallback to poller replication lag if heartbeat lag fails#372
Merged
timvaillancourt merged 2 commits intoslack-15.0from May 28, 2024
Merged
slack-15.0: Fallback to poller replication lag if heartbeat lag fails#372timvaillancourt merged 2 commits intoslack-15.0from
slack-15.0: Fallback to poller replication lag if heartbeat lag fails#372timvaillancourt merged 2 commits intoslack-15.0from
Conversation
* Fallback to poller replication lag if heartbeat lag fails Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Try to make CI pipeline happy Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Address PR comments Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix typo Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Eduardo J. Ortega U. <5791035+ejortegau@users.noreply.github.com> --------- Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Eduardo J. Ortega U. <5791035+ejortegau@users.noreply.github.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt
changed the title
slack-15.0: Fallback to poller replication lag if heartbeat lag fails (#207)slack-15.0: Fallback to poller replication lag if heartbeat lag fails
tanjinx
approved these changes
May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This ports this custom patch to v15. We may want to consider upstreaming this - by our next major-release we won't need this patch, too
Related Issue(s)
Checklist
Deployment Notes