Add 'VStreamerCount' metric to vttablet#32
Merged
timvaillancourt merged 7 commits intoslack-vitess-r13.0.3from Dec 16, 2022
Merged
Add 'VStreamerCount' metric to vttablet#32timvaillancourt merged 7 commits intoslack-vitess-r13.0.3from
timvaillancourt merged 7 commits intoslack-vitess-r13.0.3from
Conversation
timvaillancourt
commented
Dec 13, 2022
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
tanjinx
approved these changes
Dec 14, 2022
…t' into vstream-count-metric
vmogilev
approved these changes
Dec 15, 2022
timvaillancourt
changed the title
Author
|
Adding suggestions from upstream PR vitessio#11978 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
VStreamersActiveVStreamerCountstats metric tovttabletso that the number of active streams is observable. Using the already-existingVStreamersCreatedmetric alone doesn't provide an accurate view of the number of streams running on a tablet because they could have endedA simple
len(vse.streamers)is used to detect number of active streamers, as this map has entries for active streams onlyUpon successful testing I plan to submit this change upstream
Related Issue(s)
Checklist
Deployment Notes