slack-vitess-r15.0.5: use go1.20.14#255
Merged
timvaillancourt merged 13 commits intoslack-vitess-r15.0.5from Mar 15, 2024
Merged
slack-vitess-r15.0.5: use go1.20.14#255timvaillancourt merged 13 commits intoslack-vitess-r15.0.5from
slack-vitess-r15.0.5: use go1.20.14#255timvaillancourt merged 13 commits intoslack-vitess-r15.0.5from
Conversation
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
There's a bunch of deprecated linters that don't work anymore, so let's remove them: ``` WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the golangci/golangci-lint#2649. ``` Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
|
Thanks for the contribution! Before we can merge this, we need @dbussink to sign the Salesforce Inc. Contributor License Agreement. |
Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
|
Thanks for the contribution! Before we can merge this, we need @dbussink @systay to sign the Salesforce Inc. Contributor License Agreement. |
…itessio#12853) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
|
Thanks for the contribution! Before we can merge this, we need @dbussink @systay @frouioui to sign the Salesforce Inc. Contributor License Agreement. |
* Upgrade release-16.0 to go1.19.6 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * upgrade to 1.20.1 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * bump the golangci-lint version Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Apply linter suggestions Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Apply linter suggestions Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix TestTLSClientVerifyIdentity Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Switch to using new Go 1.19 CRL parser (vitessio#12315) `x509.ParseCRL` is deprecated, we should use `x509.ParseRevocationList` instead which is new in Go 1.19. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Skip TestFuzz for now Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt
commented
Mar 15, 2024
| # | ||
| # I will hardcode the previous Slack release here because it is static. | ||
| # | ||
| echo slack-vitess-r14.0.5 |
Author
There was a problem hiding this comment.
NOTE: this hack makes slack-vitess-r14.0.5 the previous release for our v15 release always
Updating the version-parsing logic for Slack naming didn't go well and there is no need for this to be dynamic when we know slack-vitess-r14.0.5 is the previous release
Without this fix CI tries to use upstream's v14.0.5 tag as "previous" and this fails to build on go1.20 🙈
tanjinx
approved these changes
Mar 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the v15 release to
go1.20.14(latest) because v15's "upgrade test" passes CI ongo1.20.x. Also the Vitess "bootstrap" docker image was updated to14.1A more-recent go version was not used to avoid breaking changes in the go runtime ahead of this version
Getting CI to pass required these v16 backports:
golangci-lintand bump its version vitessio/vitess#12852release-16.0togo1.20.1vitessio/vitess#12398Related Issue(s)
Checklist
Deployment Notes