slack-vitess-r14.0.5: load --grpc_auth_static_client_creds file once#205
Merged
timvaillancourt merged 8 commits intoslack-vitess-r14.0.5from Feb 9, 2024
Merged
Conversation
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
timvaillancourt
changed the title
--grpc_auth_static_client_creds file onceslack-vitess-r14.0.5: load --grpc_auth_static_client_creds file once
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
venkatraju
reviewed
Feb 8, 2024
venkatraju
left a comment
venkatraju
left a comment
There was a problem hiding this comment.
Thanks for driving this change! Looks good. A minor comment inline
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
rvrangel
approved these changes
Feb 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR backports vitessio#15030 to our v14 branch
This is currently unmerged but got a LGTM 👍 from upstream. If there are further changes I will sync them down
Related Issue(s)
vitessio#15030
Checklist
Deployment Notes