repairReplication deadlock fix#177
Merged
vmogilev merged 10 commits intoslack-vitess-r14.0.5from Jan 27, 2024
Merged
Conversation
Signed-off-by: Vitaliy Mogilevskiy <vmogilevskiy@slack-corp.com>
tanjinx
approved these changes
Jan 26, 2024
4 tasks
This was referenced Jun 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes slow PRS (17-18s hangs) bug caused by repairReplication causing a shard deadlock as described here: https://slack-pde.slack.com/archives/C8EJ0PTPF/p1705042056083619?thread_ts=1696929303.041269&cid=C8EJ0PTPF
Testing
Extensively tested over 2 week period here and here.
Backport/Upstream Plans
see this thread
Rollout
After making a new build off of slack-vitess-r14.0.5:
dev( all keyspaces )produsingvtops-go upgrade planprodrollout via u22/high-uptime recycling