Skip to content

VStreams NOT_FOUND Error Retries and Omits Tablet #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
makinje16 merged 4 commits into from
Dec 20, 2023
Merged

VStreams NOT_FOUND Error Retries and Omits Tablet #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
149146e
add NOT_FOUND vstream error to retry but omit tablet group
makinje16 Nov 6, 2023
a3f42f4
Merge branch 'slack-vitess-r14.0.5' into vstream-not-found-patch
makinje16 Nov 29, 2023
908ac81
Merge branch 'slack-vitess-r14.0.5' into vstream-not-found-patch
makinje16 Nov 30, 2023
bb6cfbc
Merge branch 'slack-vitess-r14.0.5' into vstream-not-found-patch
makinje16 Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion go/vt/vtgate/vstream_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,8 @@ func (vs *vstream) shouldRetry(err error) (bool, bool) {

// If there is a GTIDSet Mismatch on the tablet, omit it from the candidate
// list in the TabletPicker on retry.
if errCode == vtrpcpb.Code_INVALID_ARGUMENT && strings.Contains(err.Error(), "GTIDSet Mismatch") {
if (errCode == vtrpcpb.Code_INVALID_ARGUMENT && strings.Contains(err.Error(), "GTIDSet Mismatch")) ||
errCode == vtrpc.Code_NOT_FOUND {
return true, true
}

Expand Down
7 changes: 7 additions & 0 deletions go/vt/vtgate/vstream_manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,13 @@ func TestVStreamRetriableErrors(t *testing.T) {
shouldRetry: false,
ignoreTablet: false,
},
{
name: "not found",
code: vtrpcpb.Code_NOT_FOUND,
msg: "",
shouldRetry: true,
ignoreTablet: true,
},
}

commit := []*binlogdatapb.VEvent{
Expand Down