Slack vitess r12.0.5 vtctld cherrypicks#12
Merged
tanjinx merged 2 commits intoslack-vitess-r12.0.5-vtctldfrom Sep 29, 2022
Merged
Slack vitess r12.0.5 vtctld cherrypicks#12tanjinx merged 2 commits intoslack-vitess-r12.0.5-vtctldfrom
tanjinx merged 2 commits intoslack-vitess-r12.0.5-vtctldfrom
Conversation
vmogilev
approved these changes
Sep 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These are cherrypicks needed in vtctld for vtadmin UI to work, similarly as what we did in v11 upgrade through PR
tinyspeck#247.
However, the majority changes in tinyspeck#247 are already in v12, so in this PR, just backport those are not in v12.
The branch
slack-vitess-r12.0.5-vtctldis based on the v12 release branchslack-vitess-r12.0.5, andslack-vitess-r12.0.5-vtctldwill be used for deployment.For reference:
Related Issue(s)
Checklist
Deployment Notes