Revert backup compressor from pargzip to pgzip#11
Merged
tanjinx merged 2 commits intoslack-vitess-r12.0.5from Sep 29, 2022
Merged
Revert backup compressor from pargzip to pgzip#11tanjinx merged 2 commits intoslack-vitess-r12.0.5from
tanjinx merged 2 commits intoslack-vitess-r12.0.5from
Conversation
vmogilev
approved these changes
Sep 29, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During v11 deployment/upgrade, we identified the backup compressor/decompressor
pargzipperforms worse thanpgzip, and we reverted it through PR tinyspeck#245, (the upstream vitessio#8174).And in upstream main branch, we do have a new feature to support external backup compressor as a new backup argument vitessio#10558, we can consider it in next release upgrade, but for now, we just revert to
pgzip.details in thread
Related Issue(s)
Checklist
Deployment Notes