Make robolectric sdk downloads less hardcoded #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reworks how we handle robolectric jar downloads by allowing the consumer side to potentially force a newer version and load SDKs from the newer robolectric SDK. Still not super ideal as it requires putting robolectric on the buildscript classpath, but it's an impl dep at least and hopefully we can iterate on it in the future (maybe making the coordinate downloads a direct download rather than use the gradle resolver?)
kateliu20
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks how we handle robolectric jar downloads by allowing the consumer side to potentially force a newer version and load SDKs from the newer robolectric SDK. Still not super ideal as it requires putting robolectric on the buildscript classpath, but it's an impl dep at least and hopefully we can iterate on it in the future (maybe making the coordinate downloads a direct download rather than use the gradle resolver?)
I think eventually it would be helpful to spin this out to a separate, reusable plugin as we're definitely not the only ones with this issue.