Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to multipreview annotations in docs #418

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

erikghonyan
Copy link
Contributor

The existing link redirects to https://developer.android.com/develop/ui/compose/tooling#preview-multipreview which is a tooling overview page and doesn't mention multipreviews

Copy link

salesforce-cla bot commented Oct 2, 2024

Thanks for the contribution! Before we can merge this, we need @erikghonyan to sign the Salesforce Inc. Contributor License Agreement.

Copy link
Collaborator

@ZacSweers ZacSweers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge once you've signed the CLA!

@erikghonyan
Copy link
Contributor Author

Thanks Zac! It looks like something didn't go right, I did get a "Something went wrong" when trying to sign it the first time but when I try again it says I've already signed it? 🤷

Screenshot 2024-10-02 at 17 57 20

Is there a way to reset it or something? Otherwise, I can close the PR and you can make the change if you want (would be nice to be able to contribute again though)

@ZacSweers ZacSweers closed this Oct 2, 2024
@ZacSweers ZacSweers reopened this Oct 2, 2024
@ZacSweers
Copy link
Collaborator

Annoyingly, closing/reopening is how we fix this apparently. Thanks!

@erikghonyan
Copy link
Contributor Author

Heh, nice! 😄

@ZacSweers ZacSweers added this pull request to the merge queue Oct 2, 2024
Merged via the queue into slackhq:main with commit 21e2260 Oct 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants