Fix allowed names for Unit-returning functions #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @dellisd to sign the Salesforce Inc. Contributor License Agreement. |
ZacSweers
reviewed
Jun 21, 2023
|
This only disables the lint if you've added the function name to the allowed names, doesn't it? That seems fine to me if you have a specific function name that you want to disable this rule on in many (many) places, but not actually disable it in general. |
|
Hmmm I'm not sure. @chrisbanes @mrmans0n thoughts? |
chrisbanes
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The allowed names for the naming detector were only being checked for compsable functions that returned a value. For functions that return nothing or Unit, the allowed names would have no effect.