Add sizeInBytes field #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @kx-chen to sign the Salesforce Inc. Contributor License Agreement. |
bryanlb
requested changes
May 31, 2024
astra/src/test/java/com/slack/astra/metadata/snapshot/SnapshotMetadataSerializerTest.java
Show resolved
Hide resolved
kx-chen
force-pushed
the
kx-chen/add-size-metadata
branch
3 times, most recently
from
a4aea70
to
6c7faae
Compare
kx-chen
force-pushed
the
kx-chen/add-size-metadata
branch
from
6c7faae
to
0156958
Compare
bryanlb
approved these changes
Jun 4, 2024
Used to keep track of size of chunks in prepartion for dynamic chunk sizes
kx-chen
force-pushed
the
kx-chen/add-size-metadata
branch
from
0156958
to
b1ac5ee
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add sizeInBytes field to
SnapshotMetadataandChunkInfo. Used to keep track of size of chunks in preparation for dynamic chunk sizes.Requirements