clarify user id vs name #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengill
approved these changes
Dec 13, 2021
ndeloof
reviewed
Dec 22, 2021
| @@ -69,7 +69,7 @@ Add this Action as a [step][job-step] to your project's GitHub Action Workflow f | |||
| id: slack | |||
| uses: slackapi/[email protected] | |||
| with: | |||
| channel-id: 'CHANNEL_ID' # Slack channel id or name to post message. https://api.slack.com/methods/chat.postMessage#channels | |||
| channel-id: 'CHANNEL_ID' # Slack channel id or user id to post message. https://api.slack.com/methods/chat.postMessage#channels | |||
There was a problem hiding this comment.
that's nice to document one can use user ID, but this action also accepts a channel name (general) and does not require a channel ID, as this update suggests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As shown in #40 - Since we don't support usernames (rather user ids), this tweak clarifies the usage instructions.
Requirements (place an
xin each[ ])