Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding automated build & tag update on release #23

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Adding automated build & tag update on release #23

merged 1 commit into from
Nov 16, 2021

Conversation

robzr
Copy link
Contributor

@robzr robzr commented Nov 9, 2021

Summary

As identified in #16, there are no automated builds or releases being done. This added workflow will build on release and update the associated major/minor tracking tags - if you do a v1.16.0 release; it will build, update the dist/index.json to a new commit, then update the release tag as well as the tracking tags v1 and v1.16 automatically.

It will still require someone manually making a new version release after a merge to master. This could further be automated to use a merge commit message.

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented Nov 9, 2021

CLA assistant check
All committers have signed the CLA.

@robzr robzr mentioned this pull request Nov 9, 2021
4 tasks
@stevengill stevengill self-requested a review November 10, 2021 06:34
@m5kr1pka
Copy link
Contributor

m5kr1pka commented Nov 10, 2021

@stevengill maybe Google's automated Release Please Action would be a more appropriate approach for an enterprise level action with Conventional Commit Messages.

@robzr
Copy link
Contributor Author

robzr commented Nov 16, 2021

@stevengill maybe Google's automated Release Please Action would be a more appropriate approach for an enterprise level action with Conventional Commit Messages.

Right now there is no CI building, and the last merge to master wasn't built or released, so this at least fixes that.

release-please-action looks interesting, but it is an opinionated flow that would require all contributors to buy into "CCM", so that's a cultural change.

@stevengill stevengill added the enhancement New feature or request label Nov 16, 2021
@stevengill
Copy link
Member

This is great! Thank you!!

@stevengill stevengill merged commit 6b7934f into slackapi:main Nov 16, 2021
@robzr robzr deleted the feature/automated_release branch November 16, 2021 17:35
@seratch seratch modified the milestones: 1.17, 1.16 Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants