Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

204: Handle proxies when using Slack WebClient #205

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

raihle
Copy link
Contributor

@raihle raihle commented May 30, 2023

Summary

Requirements (place an x in each [ ])

The CLA mentioned in the Contributing Guidelines could not be found, but I'm (probably) willing to sign it if you can point me in the right direction. The bot took care of that promptly!

@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @raihle to sign the Salesforce Inc. Contributor License Agreement.

@hello-ashleyintech hello-ashleyintech self-requested a review May 31, 2023 14:31
@hello-ashleyintech hello-ashleyintech self-assigned this May 31, 2023
@hello-ashleyintech hello-ashleyintech added the enhancement New feature or request label May 31, 2023
@hello-ashleyintech hello-ashleyintech added this to the 1.25 milestone May 31, 2023
@hello-ashleyintech
Copy link
Contributor

hello-ashleyintech commented May 31, 2023

Hi, @raihle! Thanks so much for opening this PR 🙌 This is looking good so far! I'm going to run the integration tests on my end to make sure all looks good, but it's a great sign that the unit tests are passing, especially with the updates to slack-send!

At first glance the two use cases you provided for the web client test make sense. I have to get access to a particular workspace to run the integration tests, so I'll drop in an update once I'm able to run these with the results as well as if I have any additional thoughts on the test cases! 👍

Copy link
Contributor

@hello-ashleyintech hello-ashleyintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raihle Great news - this is looking good on my end and I have confirmed through #206 that the integration tests pass!

This PR is currently failing the payload integration test due to a non-related issue that was uncovered where that test is having trouble parsing certain characters when they're in the body of a PR. I have a fix for that in #207. Waiting for approval for that one, and then once that has been merged in and the integration test is updated, I'll approve and merge this one in as well. Also - I have left one small comment on testing that I would like to get your thoughts on before approving and merging, so let me know if there are any questions there! 😄

test/web-client-test.js Show resolved Hide resolved
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's also document the ability to use https_proxy and HTTPS_PROXY environment variables in the README.

Copy link
Contributor

@hello-ashleyintech hello-ashleyintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed integration tests for this code are passing in #206 and documentation for the HTTPS_PROXY env var has been added. This is looking great to me, so I'll approve and merge this - thanks so much for your contribution, @raihle! 🙇

@raihle
Copy link
Contributor Author

raihle commented Jun 1, 2023

@filmaj Good call, I added a new section (sibling to the techniques) with an example using HTTPS_PROXY.

@hello-ashleyintech hello-ashleyintech merged commit c70e795 into slackapi:main Jun 1, 2023
@filmaj
Copy link
Contributor

filmaj commented Jun 1, 2023

Thank you so much for your contribution!

PhuongTMR pushed a commit to PhuongTMR/slack-github-action that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy configuration is ignored when using bot token
3 participants