Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

payload-file-path does not respect env variables in the payload JSON file #51

Closed
4 of 10 tasks
seratch opened this issue Jan 17, 2022 · 0 comments · Fixed by #71
Closed
4 of 10 tasks

payload-file-path does not respect env variables in the payload JSON file #51

seratch opened this issue Jan 17, 2022 · 0 comments · Fixed by #71
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
1.19

Comments

@seratch
Copy link
Member

seratch commented Jan 17, 2022 •
edited
Loading

Description

If you have variables embedded in payload-file-path JSON data, the variables won't be expanded.

You can do tests with the following:

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@seratch seratch added bug Something isn't working good first issue Good for newcomers labels Jan 17, 2022
@seratch seratch added this to the 1.18 milestone Jan 17, 2022
@seratch seratch modified the milestones: 1.18, 1.19 Jan 27, 2022
nitintecg pushed a commit to nitintecg/slack-github-action that referenced this issue Mar 6, 2022
fixed slackapi#51 for env variables in payload json file
502babf
@nitintecg nitintecg mentioned this issue Mar 6, 2022
Merged
2 tasks
@filmaj filmaj closed this as completed in #71 Mar 7, 2022
filmaj pushed a commit that referenced this issue Mar 7, 2022
@filmaj
fixed #51 for env variables in payload json file
2f8da78
@ylkhayat ylkhayat mentioned this issue Apr 23, 2022
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
1.19
Development

Successfully merging a pull request may close this issue.

fixed #51 for env variables in payload json file nitintecg/slack-github-action
1 participant
@seratch