Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2.x] Fix #891 by adding warnings for missing text parameter #910

Merged
merged 2 commits into from
Jan 8, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Jan 5, 2021

Summary

This pull request fixes #891 by adding warnings for chat.* methods. I am asking for feedback at slackapi/java-slack-sdk#657 - the warning message can be changed before merging this PR.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (Web API client)
  • slack_sdk.webhook.WebhookClient (Incoming Webhook, response_url sender)
  • slack_sdk.models (UI component builders)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.rtm.RTMClient (RTM client)
  • slack_sdk.signature (Request Signature Verifier)
  • /docs-src (Documents, have you run ./docs.sh?)
  • /docs-src-v2 (Documents, have you run ./docs-v2.sh?)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python setup.py validate after making the changes.

@seratch seratch added enhancement M-T: A feature request for new functionality web-client Version: 3x labels Jan 5, 2021
@seratch seratch added this to the 3.1.1 milestone Jan 5, 2021
@seratch seratch self-assigned this Jan 5, 2021
@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #910 (9c7e072) into main (7680286) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #910      +/-   ##
==========================================
+ Coverage   87.93%   87.94%   +0.01%     
==========================================
  Files          35       35              
  Lines        3381     3385       +4     
==========================================
+ Hits         2973     2977       +4     
  Misses        408      408              
Impacted Files Coverage Δ
slack_sdk/web/legacy_client.py 97.06% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7680286...9c7e072. Read the comment docs.

Copy link
Member

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seratch seratch modified the milestones: 3.1.1, 3.2.0 Jan 5, 2021
@seratch seratch force-pushed the issue-891-missing-text-warning branch from 6019525 to e739ff7 Compare January 7, 2021 02:00
@seratch seratch changed the title Fix #891 by adding warnings for missing text parameter [3.2.x] Fix #891 by adding warnings for missing text parameter Jan 7, 2021
@seratch seratch force-pushed the issue-891-missing-text-warning branch from e739ff7 to 1402689 Compare January 7, 2021 02:21
@seratch seratch merged commit e05af1f into slackapi:main Jan 8, 2021
@seratch seratch deleted the issue-891-missing-text-warning branch February 15, 2021 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality Version: 3x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn when chat.postMessage is called without text argument
2 participants