Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set team id to none on enterprise installs #1640

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GabeL7r
Copy link

@GabeL7r GabeL7r commented Jan 23, 2025

Summary

When I'm using Python Bolt and install a Slack App at the enterprise level a team_id is supplied in the installation. This results in saving the installation with an enterprise id and team id, however, when retrieving the installation only the enterprise id is used, this should resolve the problem.

#1639

Testing

Run tests.

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs (Documents)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

Copy link

Thanks for the contribution! Before we can merge this, we need @GabeL7r to sign the Salesforce Inc. Contributor License Agreement.

self.team_id = team_id
# Note: when performing an enterprise install a team id
# is still supplied by Python Bolt, but it is not relevant.
if not is_enterprise_install:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could potentially break the callers if they are retrieving the team_id from the installation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant