-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve flaky tests #1615
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1615 +/- ##
==========================================
+ Coverage 84.89% 85.01% +0.11%
==========================================
Files 113 113
Lines 12639 12639
==========================================
+ Hits 10730 10745 +15
+ Misses 1909 1894 -15 ☔ View full report in Codecov by Sentry. |
# running Task gets suspended, and the event loop executes the next Task. | ||
# To schedule a callback from another OS thread, the loop.call_soon_threadsafe() method should be used. | ||
# https://docs.python.org/3/library/asyncio-dev.html#asyncio-multithreading | ||
test.loop.call_soon_threadsafe(test.loop.stop) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this line is creating more stability; taken from bolt-python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This is AMAZING
Summary
This PR aims to improve flaky tests in our CI pipeline and consolidate the mock socket mode clients found in this project
Testing
Ran the Ci pipeline a few times did not observe any flaking tests
Category
/docs
(Documents)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.