Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill out remaining method arguments #512

Merged
merged 2 commits into from
Mar 21, 2018
Merged

Conversation

clavin
Copy link
Contributor

@clavin clavin commented Mar 17, 2018

Summary

Fixes #505. Implements the remaining method arguments.

The only remaining incomplete type definitions for arguments is actions of MessageAttachments.

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Mar 17, 2018

Codecov Report

Merging #512 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #512   +/-   ##
=======================================
  Coverage   81.32%   81.32%           
=======================================
  Files           6        6           
  Lines         241      241           
  Branches       37       37           
=======================================
  Hits          196      196           
  Misses         29       29           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a206c3e...32fd154. Read the comment docs.

@clavin clavin mentioned this pull request Mar 17, 2018
2 tasks
@aoberoi
Copy link
Contributor

aoberoi commented Mar 21, 2018

😮

this is so amazing. thanks so much @clavin!

@aoberoi aoberoi merged commit 4bdbd79 into slackapi:master Mar 21, 2018
@clavin clavin deleted the fix-issue-505 branch March 21, 2018 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants