-
Notifications
You must be signed in to change notification settings - Fork 674
Issue-268: Websocket login respects https_proxy environment variable #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@aoberoi Could I convince you give this a review? I'm inclined to 👍 but I'd like your eyes on it too. |
In the meantime, @liuweichu I see that the linter is rejecting your changes. In particular, we require string literals to use single-quotes, and all lines to be terminated with semi-colons. These issues must be resolved before we can accept this PR. I apologize that this has taken me so long to come back around to, and I am eager to get this merged in! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, it doesn't look like @liuweichu actually signed the CLA. We cannot approve without a signed CLA :(
@DEGoodmanWilson Thanks for lintering
|
1 similar comment
Oops I missed this mention! I'll find a better way to deal with the notifications moving forward. |
PR Summary
If
https_proxy
is set, slack websocket will use the proxy to connect to slack server.This solves the issue that
hubot-slack
cannot login behind firewall.Related Issues
Fixes #268
Test strategy
The code is running great in our production env, no test case is written though. (If test is required, please guide me how to write