Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #593 New option to ignore events by other workspace users in shared channels #597

Merged
merged 3 commits into from
May 18, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented May 14, 2020

Summary

This pull request fixes #593 by adding a new option named installedTeamOnly to configure Hubot not to react to other workspace users in a shared channel.

HUBOT_SLACK_TOKEN=xoxb-*** INSTALLED_TEAM_ONLY=true ./bin/hubot --adapter slack

Requirements (place an x in each [ ])

@seratch seratch added the enhancement M-T: A feature request for new functionality label May 14, 2020
@seratch seratch requested review from stevengill and aoberoi May 14, 2020 09:03
@seratch seratch self-assigned this May 14, 2020
@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #597 into master will decrease coverage by 0.92%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
- Coverage   85.25%   84.32%   -0.93%     
==========================================
  Files           6        6              
  Lines         400      402       +2     
  Branches       88       90       +2     
==========================================
- Hits          341      339       -2     
- Misses         34       37       +3     
- Partials       25       26       +1     
Impacted Files Coverage Δ
src/bot.coffee 73.10% <33.33%> (-2.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9db6a0c...d7232fc. Read the comment docs.

@seratch seratch added this to the 4.8.0 milestone May 15, 2020
@seratch seratch merged commit 3276b66 into slackapi:master May 18, 2020
@seratch seratch deleted the issue-593-installed-team-only branch June 3, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New option to ignore events by other workspace users in shared channels
2 participants