Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removeFormatting does not work for subteams #288

Closed
jabbink opened this issue Mar 23, 2016 · 4 comments · Fixed by #373
Closed

removeFormatting does not work for subteams #288

jabbink opened this issue Mar 23, 2016 · 4 comments · Fixed by #373
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented

Comments

@jabbink
Copy link

jabbink commented Mar 23, 2016

When trying to parse an unformatted message, subteams get replaced by undefined

text: 'undefined hello',
rawText: '<!subteam^xxx|@yyy> hello',

https://github.com/slackhq/hubot-slack/blob/master/src/slack.coffee#L174
sanderploegsma added a commit to WISVCH/florriebot that referenced this issue Mar 23, 2016
@sanderploegsma
Fix for issue with slack adapter
c5e8a6b 
Note: this should be a temporary fix, to be reverted when slackapi/hubot-slack#288 is resolved
@sanderploegsma sanderploegsma mentioned this issue Mar 23, 2016
Merged
@UncannyBingo
Copy link

No doubt related to, and will be fixed with #114 This is pretty high-priority stuff, and it's not strictly speaking a duplicate, but I am going to mark it as a duplicate since fixing this and fixing #114 are almost assuredly the same thing.

@UncannyBingo UncannyBingo added the duplicate An issue for the same purpose already exists, and a link is in the comments label Jun 27, 2016
@UncannyBingo
Copy link

Oops, didn't mean to close the issue!

@UncannyBingo UncannyBingo reopened this Jun 27, 2016
@UncannyBingo UncannyBingo added Priority—High bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented and removed duplicate An issue for the same purpose already exists, and a link is in the comments labels Jun 27, 2016
@UncannyBingo
Copy link

Closing this as fixed in 4.0. Please reopen if I am mistaken!

@ndaversa
Copy link
Contributor

ndaversa commented Nov 1, 2016

@DEGoodmanWilson This still seems broken to me in v4.2.1

#366 does seem to resolve the issue though

@ndaversa ndaversa mentioned this issue Nov 1, 2016
Closed
6 tasks
@ndaversa ndaversa mentioned this issue Nov 9, 2016
Merged
6 tasks
UncannyBingo pushed a commit that referenced this issue Nov 10, 2016
@ndaversa
Improve the SlackFormatter to add support for subteams and fix (#373)
65d9209 
channel/username linking inconsistency Fixes #288 #366 #361 #333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve the SlackFormatter to add support for subteams and fix inconsistencies
3 participants
@ndaversa @UncannyBingo @jabbink