Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SocketMode Test #987

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

WilliamBergamin
Copy link
Contributor

This PR aims to fix a broken tests that seems to have originated from a the changes introduced by 1379 in the python sdk

I think the changes made to the python sdk require the socket mode mock to wait for connection without retrying before testing if the connection is made

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@WilliamBergamin WilliamBergamin added the bug Something isn't working label Nov 17, 2023
@WilliamBergamin WilliamBergamin self-assigned this Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed19abc) 91.77% compared to head (ec0fadc) 91.77%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #987   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         181      181           
  Lines        6309     6309           
=======================================
  Hits         5790     5790           
  Misses        519      519           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamBergamin WilliamBergamin mentioned this pull request Nov 17, 2023
8 tasks
@seratch seratch added this to the 1.18.1 milestone Nov 17, 2023
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this!

@seratch seratch merged commit 970956b into slackapi:main Nov 17, 2023
11 checks passed
@WilliamBergamin WilliamBergamin deleted the fix-broken-test branch November 20, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants