Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve token rotation error handling and installation error text #861

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented Mar 15, 2023

This pull request improves the built-in middleware to better handle token rotation errors. Also, I've updated the built-in error text message in the scenario.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added this to the 1.17.0 milestone Mar 15, 2023
@seratch seratch self-assigned this Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #861 (3b6d3ad) into main (84bb73d) will decrease coverage by 0.23%.
The diff coverage is 48.38%.

❗ Current head 3b6d3ad differs from pull request most recent head 9b2928d. Consider uploading reports for the commit 9b2928d to get more accurate results

@@            Coverage Diff             @@
##             main     #861      +/-   ##
==========================================
- Coverage   92.00%   91.78%   -0.23%     
==========================================
  Files         181      181              
  Lines        6242     6269      +27     
==========================================
+ Hits         5743     5754      +11     
- Misses        499      515      +16     
Impacted Files Coverage Δ
...dleware/authorization/single_team_authorization.py 85.29% <0.00%> (-8.26%) ⬇️
...e/authorization/async_single_team_authorization.py 85.71% <25.00%> (-8.04%) ⬇️
slack_bolt/authorization/async_authorize.py 82.84% <28.57%> (-2.44%) ⬇️
slack_bolt/authorization/authorize.py 82.53% <28.57%> (-2.47%) ⬇️
...k_bolt/middleware/authorization/async_internals.py 100.00% <100.00%> (ø)
...e/authorization/async_multi_teams_authorization.py 93.02% <100.00%> (+0.52%) ⬆️
slack_bolt/middleware/authorization/internals.py 100.00% <100.00%> (ø)
...dleware/authorization/multi_teams_authorization.py 90.47% <100.00%> (+0.73%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit 8334d17 into main Mar 15, 2023
@seratch seratch deleted the rotation-error branch March 15, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant