Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pytype, black versions #547

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Conversation

seratch
Copy link
Member

@seratch seratch commented Dec 14, 2021

This pull request upgrades the following dev tool versions:

  • pytype
  • black

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added this to the 1.11.0 milestone Dec 14, 2021
@seratch seratch self-assigned this Dec 14, 2021
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #547 (e36278e) into main (dc09c4c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #547   +/-   ##
=======================================
  Coverage   91.35%   91.35%           
=======================================
  Files         169      169           
  Lines        5647     5647           
=======================================
  Hits         5159     5159           
  Misses        488      488           
Impacted Files Coverage Δ
slack_bolt/context/base_context.py 100.00% <ø> (ø)
slack_bolt/adapter/falcon/resource.py 84.61% <100.00%> (ø)
slack_bolt/adapter/sanic/async_handler.py 85.36% <100.00%> (ø)
slack_bolt/adapter/tornado/handler.py 87.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc09c4c...e36278e. Read the comment docs.

@seratch seratch merged commit 68e792e into slackapi:main Dec 14, 2021
@seratch seratch deleted the pytype-black-upgrade branch December 14, 2021 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant