Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update Bolt Python Assistant doc to match JS structure. #1239

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

technically-tracy
Copy link
Contributor

@technically-tracy technically-tracy commented Jan 28, 2025

Summary

Update Bolt Python Assistant doc to match JS structure.

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you; this is great!

@seratch seratch added the docs Improvements or additions to documentation label Jan 28, 2025
@seratch seratch added this to the 1.22.1 milestone Jan 28, 2025
@WilliamBergamin
Copy link
Contributor

WilliamBergamin commented Jan 28, 2025

Not sure whats going on with these tests 🤔 let me know if you would like some help with them, I don't think you changes have anything to do with this

@technically-tracy
Copy link
Contributor Author

Not sure whats going on with these tests 🤔 let me know if you would like some help with them, I don't think you changes have anything to do with this

Yeah, I have no idea 😬 I tried to re-run them, but they're still failing.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (276eae6) to head (c8cf99f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1239   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         222      222           
  Lines        7501     7501           
=======================================
  Hits         6823     6823           
  Misses        678      678           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technically-tracy technically-tracy merged commit 42af666 into main Jan 30, 2025
16 checks passed
@technically-tracy technically-tracy deleted the tracy-assistant-structure-py branch January 30, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants