Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update sanic requirement from <24,>=22 to >=22,<25 #1233

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 1, 2025

Updates the requirements on sanic to permit the latest version.

Release notes

Sourced from sanic's releases.

Version 24.12

What's Changed

New Contributors

Full Changelog: sanic-org/sanic@v24.6.0...v24.12.0

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [sanic](https://github.com/sanic-org/sanic) to permit the latest version.
- [Release notes](https://github.com/sanic-org/sanic/releases)
- [Commits](sanic-org/sanic@v22.3.0...v24.12.0)

---
updated-dependencies:
- dependency-name: sanic
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jan 1, 2025
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (6d34c7d) to head (db27e07).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1233   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         222      222           
  Lines        7501     7501           
=======================================
  Hits         6823     6823           
  Misses        678      678           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Updates the requirements on [sanic](https://github.com/sanic-org/sanic) to permit the latest version.
- [Release notes](https://github.com/sanic-org/sanic/releases)
- [Commits](sanic-org/sanic@v22.3.0...v24.12.0)

---
updated-dependencies:
- dependency-name: sanic
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/sanic-gte-22-and-lt-25 branch from 4a21e03 to 3488d95 Compare January 3, 2025 21:38
@seratch
Copy link
Member

seratch commented Jan 6, 2025

It seems something has been changed on Sanic side since v25:

________ ERROR collecting tests/adapter_tests_async/test_async_sanic.py ________
tests/adapter_tests_async/test_async_sanic.py:7: in <module>
    from sanic import Sanic
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/sanic/__init__.py:6: in <module>
    from sanic.app import Sanic
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/sanic/app.py:50: in <module>
    from sanic.application.state import ApplicationState, ServerStage
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/sanic/application/state.py:12: in <module>
    from sanic.log import VerbosityFilter, logger
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/sanic/log.py:1: in <module>
    from sanic.logging.color import Colors
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/sanic/logging/color.py:8: in <module>
    from sanic.helpers import is_atty
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/sanic/helpers.py:[21](https://github.com/slackapi/bolt-python/actions/runs/12604289956/job/35130902961?pr=1233#step:18:22): in <module>
    STATUS_CODES: dict[int, bytes] = {
E   TypeError: 'type' object is not subscriptable

@WilliamBergamin WilliamBergamin self-assigned this Jan 6, 2025
@WilliamBergamin
Copy link
Contributor

@seratch I made a commit on this PR that changes which version of sanic is installed based on the version of python

Python 3.6 -> sanic 20
Python 3.7 and 3.8 -> sanic 21,<24
Python 3.9 and above -> sanic 21,<25

@seratch
Copy link
Member

seratch commented Jan 7, 2025

@WilliamBergamin Nice! Thanks for resolving it 👍

@seratch seratch merged commit 4fce092 into main Jan 7, 2025
14 checks passed
@seratch seratch deleted the dependabot/pip/sanic-gte-22-and-lt-25 branch January 7, 2025 01:54
@WilliamBergamin WilliamBergamin modified the milestones: 1.x, 1.22.1 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:adapter area:async dependencies Pull requests that update a dependency file good first issue python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants