Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve metadata resolution timing in assistant app's say method #1186

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

seratch
Copy link
Member

@seratch seratch commented Oct 24, 2024

This pull request improves the Assistant middleware's internals. Like the asyncio version already does, the get_thread_context method call should be delayed until it's really necessary: https://github.com/slackapi/bolt-python/blob/v1.21.1/slack_bolt/context/assistant/async_assistant_utilities.py#L69-L80

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added enhancement New feature or request improvement labels Oct 24, 2024
@seratch seratch added this to the 1.21.2 milestone Oct 24, 2024
@seratch seratch requested review from filmaj and misscoded October 24, 2024 01:07
@seratch seratch self-assigned this Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.93%. Comparing base (18a9135) to head (96201d6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1186      +/-   ##
==========================================
+ Coverage   90.92%   90.93%   +0.01%     
==========================================
  Files         222      222              
  Lines        7495     7505      +10     
==========================================
+ Hits         6815     6825      +10     
  Misses        680      680              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch
Copy link
Member Author

seratch commented Oct 24, 2024

Thanks for the swift review!

@seratch seratch merged commit 38167c4 into slackapi:main Oct 24, 2024
12 checks passed
@seratch seratch deleted the metadata-resolve-timing branch October 24, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants