Fix double quoted img alt text #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @toofishes to sign the Salesforce Inc. Contributor License Agreement. |
This attribute looks like it was erroneously double quoted, causing the HTML element as rendered by most browsers to not have alt text. Adjust the quoting to match the other attributes.
toofishes
force-pushed
the
fix-img-alt-text
branch
from
ef4428f to
20e16a2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1170 +/- ##
=======================================
Coverage 92.02% 92.02%
=======================================
Files 195 195
Lines 6631 6631
=======================================
Hits 6102 6102
Misses 529 529 ☔ View full report in Codecov by Sentry. |
zimeg
approved these changes
Sep 28, 2024
There was a problem hiding this comment.
Hey @toofishes! 👋 Thanks a ton for catching this!
I'm not sure what the original HTML might've been doing, but this contribution is so appreciated in all cases. Let's merge it for the next release! 🚀 ✨
| @@ -221,6 +221,6 @@ async def endpoint(req: Request): | |||
|
|
|||
| # NOTE: Although sanic-testing 0.6 does not have this value, | |||
| # Sanic apps properly generate the content-length header | |||
| # assert response.headers.get("content-length") == "609" | |||
| # assert response.headers.get("content-length") == "607" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute looks like it was erroneously double quoted, causing the HTML element as rendered by most browsers to not have alt text. Adjust the quoting to match the other attributes.
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.