Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: naming of is_coroutine_function #1134

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

WilliamBergamin
Copy link
Contributor

This is a follow up to #1132, take it or leave it

These changes rename is_coroutine_function to is_callable_coroutine. Callables can be a function/method or an instances of a class that has a __call__() method. This naming aims to be more descriptive.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.01%. Comparing base (9dcc0fb) to head (1a8dfc3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1134   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files         195      195           
  Lines        6616     6616           
=======================================
  Hits         6088     6088           
  Misses        528      528           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this could be indeed better naming

@seratch seratch merged commit 6f4854b into slackapi:main Aug 21, 2024
12 checks passed
@WilliamBergamin WilliamBergamin deleted the imporve-callable-coroutine branch August 22, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants