Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: sidebar reference link needs to be full URL #1117

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

lukegalbraithrussell
Copy link
Contributor

The link works - try refreshing the page and it'll load - but it's not liking the relative link initially for some reason

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • [] I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@lukegalbraithrussell lukegalbraithrussell added docs Improvements or additions to documentation bug Something isn't working labels Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.80%. Comparing base (5ef7023) to head (1b35147).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1117   +/-   ##
=======================================
  Coverage   91.80%   91.80%           
=======================================
  Files         186      186           
  Lines        6408     6408           
=======================================
  Hits         5883     5883           
  Misses        525      525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukegalbraithrussell lukegalbraithrussell merged commit 5a5863c into main Aug 2, 2024
14 checks passed
@lukegalbraithrussell lukegalbraithrussell deleted the luke-docs-reference-sidebar-link branch August 2, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants