Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #1017, it aim to speed up unit test execution
Many unit tests use
asyncio.sleep
before asserting that a request tomock_web_api_server
was successfully processed. These changes allow unit tests tocontinue
as soon as requests tomock_web_api_server
are processed, instead of waiting an arbitrary amount of time.This reuses the same logic introduced by #1017 and applies it to the
async
area of the unit tests.Original
Before this PR
After
Take away
In GitHub actions using
python 3.11
, this PR allows the unit tests to run in2m18s
this is a38%
improvement compared to3m45s
previously and a54%
improvement compare to executions pre #1017On my local machine using python 3.11, this PR allows the unit tests to run in
1m35s
this is a43%
improvement compared to2m49s
previouslyCategory (place an
x
in each of the[ ]
)slack_bolt.App
and/or its core componentsslack_bolt.async_app.AsyncApp
and/or its core componentsslack_bolt.adapter
/docs
Requirements (place an
x
in each[ ]
)Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.sh
after making the changes.