Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused multiprocessing test mode #1011

Merged

Conversation

WilliamBergamin
Copy link
Contributor

This PR aims to remove the logic that implements the multiprocessing testing mode (in favor of the threading mode). This mode is no longer used in CI/CD or development.

This PR paves the path to implement similar changes brought to the slack-sdk in #1445 that replaces the Flask-Sockets dependency with aiohttp

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e63905) 91.76% compared to head (1b86be7) 91.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1011   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files         181      181           
  Lines        6312     6312           
=======================================
  Hits         5792     5792           
  Misses        520      520           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

.github/workflows/codecov.yml Outdated Show resolved Hide resolved
tests/adapter_tests/socket_mode/mock_socket_mode_server.py Outdated Show resolved Hide resolved
@seratch seratch added this to the 1.18.2 milestone Jan 10, 2024
@WilliamBergamin WilliamBergamin merged commit f150cfd into slackapi:main Jan 10, 2024
12 checks passed
@WilliamBergamin WilliamBergamin deleted the remove-multiprocessing-faking branch January 10, 2024 22:18
@seratch seratch modified the milestones: 1.18.2, 1.19.0 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants