Change dependencies to peerDependencies #2147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: Installation of the package `@slack/bolt` has next file structure: ```node_modules/@slack/bolt/node_modules``` Which brings complexity to the application. Also it makes impossible to override package veersions. Renaming `dependencies` -> `peerDependencies` helps to get rid of this problem.
|
Thanks for the contribution! Before we can merge this, we need @vadjs to sign the Salesforce Inc. Contributor License Agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Installation of the package
@slack/bolthas next file structure:node_modules/@slack/bolt/node_modulesWhich brings complexity to the application. Also it makes it impossible to override package versions.
Renaming
dependencies->peerDependencieshelps to get rid of this problem.Closes #2146 (comment)
Requirements (place an
xin each[ ])