Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Patch] Mute and unmute requests #818

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[Patch] Mute and unmute requests #818

wants to merge 3 commits into from

Conversation

KarimNahas
Copy link
Contributor

PR Content:

  • Patched incorrect implementation of mute and unmute requests:
    • Incorrect body format
    • Incorrect logic in unmute

@KarimNahas
Copy link
Contributor Author

@kanata2
I've updated this branch hoping that it could get merged now:

  • Changed name of methods from MuteChat and UnMuteChat to MuteConversation and UnMuteConversation.
  • Changed signature of methods to return the updated list of muted conversations.
  • Added Context variant to the methods namely (GetUserPrefsContext, MuteChatContext and UnMuteChatContext).
  • Added tests for MuteConversation and UnMuteConversation.
  • Added comments on methods.
    Let me know if anything else needs to be done.

kanata2
kanata2 reviewed Mar 16, 2021
View reviewed changes
conversation.go
}
response := UserPrefsCarrier{}

err = api.postMethod(ctx, "users.prefs.set", values, &response)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this exist? I could not find Slack's documentation...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User preferences is part of the "undocumented" Slack API found here.
I've tested this in production and it is working as expected.

Copy link
Member

@kanata2 kanata2 Mar 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undocumented"

Ah, thanks 😢

@kanata2 kanata2 added the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Mar 16, 2021
@KarimNahas KarimNahas requested a review from kanata2 March 25, 2021 13:40
@kanata2 kanata2 added spec undocumented Slack does not document yet enhancement and removed feedback given When a review has been conducted and awaiting the response from the comitter(s) labels Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanata2 kanata2 Awaiting requested review from kanata2

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement needs review spec undocumented Slack does not document yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KarimNahas @kanata2